Improve accessibility for collections pages #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
force-pushed
the
collection-accessibility#3151,3152
branch
from
efa5078 to
47b1ee0
Compare
mjgiarlo
force-pushed
the
collection-accessibility#3151,3152
branch
from
47b1ee0 to
1aaf163
Compare
mjgiarlo
commented
Jun 29, 2023
| @@ -1,9 +1,10 @@ | |||
| <table class="table table-sm mb-5 caption-header"> | |||
| <caption>Details | |||
| <%= helpers.turbo_frame_tag dom_id(collection_version, :edit), | |||
| <%= helpers.turbo_frame_tag dom_id(collection_version, :edit_details), | |||
mjgiarlo
commented
Jun 29, 2023
| @@ -11,7 +11,7 @@ | |||
| <%= render CitationModalComponent.new %> | |||
| </div> | |||
| </div> | |||
| <span class="header-text"><%= name %></span><%= render Collections::DraftComponent.new(collection_version: collection_version) %> | |||
| <h1 class="header-text d-inline-block"><%= name %></h1><%= render Collections::DraftComponent.new(collection_version: collection_version) %> | |||
mjgiarlo
commented
Jun 29, 2023
| @@ -1,5 +1,5 @@ | |||
| <section class="collection-nav"> | |||
| <nav class="nav"> | |||
| <nav class="nav" role="tablist"> | |||
There was a problem hiding this comment.
Make it clear what the aria role is.
mjgiarlo
commented
Jun 29, 2023
Comment on lines
+26
to
+35
| // This removes the pagination list and if it is empty, and adds an aria | ||
| // label for its parent nav, which is done to improve accessibility. | ||
| dt.on('datatable.init', () => { | ||
| const paginationList = document.querySelector("ul.dataTable-pagination-list") | ||
| if (paginationList === null) return | ||
|
|
||
| paginationList.parentNode.setAttribute("aria-label", "Pagination Controls for Deposits") | ||
|
|
||
| if (!paginationList.hasChildNodes()) paginationList.remove() | ||
| }) |
There was a problem hiding this comment.
The changes to this file add accessibility improvements to simple-datatables.
mjgiarlo
changed the title
justinlittman
approved these changes
Jun 29, 2023
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is currently based on the commits in #3159 for easier testing, so the diff looks larger than it really is.Why was this change made? 🤔
Fixes #3151
Fixes #3152
This deals with a11y violations of the A/AA/aria variety as identified by the Siteimprove Accessibility Checker extension and the WAVE extension.
How was this change tested? 🤨
Does your change introduce accessibility violations? 🩺
No