Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip OCLC records op if not prod #1380

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Skip OCLC records op if not prod #1380

merged 2 commits into from
Nov 18, 2024

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Oct 29, 2024

Fixes #1054

@jgreben jgreben mentioned this pull request Oct 29, 2024
Closed
@jermnelson
Copy link
Collaborator

We may want to hold off merging this PR until we hear from @ahafele, I think she is still doing testing on Airflow test.

@jgreben jgreben marked this pull request as draft October 29, 2024 22:42
@jgreben jgreben marked this pull request as ready for review November 11, 2024 17:45
@jgreben jgreben force-pushed the 1054-skip-task-not-prod branch from 20e0629 to 9952c42 Compare November 18, 2024 18:15
shelleydoljack
shelleydoljack requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@shelleydoljack shelleydoljack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test test_oclc_marc_modifications got dropped inadvertently.

@jgreben jgreben force-pushed the 1054-skip-task-not-prod branch from 43c1aac to b184c50 Compare November 18, 2024 22:07
shelleydoljack
shelleydoljack approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@shelleydoljack shelleydoljack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jgreben jgreben merged commit 787c919 into main Nov 18, 2024
4 checks passed
@jgreben jgreben deleted the 1054-skip-task-not-prod branch November 18, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shelleydoljack shelleydoljack shelleydoljack approved these changes

@jermnelson jermnelson Awaiting requested review from jermnelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip transmission for transmit_data_oclc_api_task when env is not production
3 participants
@jgreben @jermnelson @shelleydoljack