Use regex pattern to get library name from fy_code #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermnelson
approved these changes
Dec 9, 2024
| return f"Fix Encumbrances for {fy_code}" | ||
|
|
||
|
|
||
| class Regex_equals(str): |
There was a problem hiding this comment.
Cool! Very useful approach for using regex in the match statement.
shelleydoljack
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1469
The email function was getting the FY_CODE (e.g. 'SUL2025') not a library string (e.g. 'sul'). This PR separates out a to_email function and implements a regex case matching class to handle matching on the FY_CODE.
Nb. Omitting Dags from Coveralls coverage, since we do not test the dags. Otherwise with this ended up being below the threshold for blacking the PR. https://github.com/sul-dlss/libsys-airflow/blob/40b1dc6ba72487d127736c8509d495ee6ad2ef01/.coveragerc