Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure encumbrance emails always get sent #1479

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Ensure encumbrance emails always get sent #1479

merged 4 commits into from
Dec 17, 2024

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Dec 16, 2024 •
edited
Loading

all_done does not include failed upstream tasks, we need to use always.

Use a try/except black to ensure com has a return value.

@jermnelson jermnelson merged commit 11853fb into main Dec 17, 2024
4 checks passed
@jermnelson jermnelson deleted the ensure-enc-emails branch December 17, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermnelson jermnelson jermnelson approved these changes

@shelleydoljack shelleydoljack shelleydoljack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgreben @jermnelson @shelleydoljack