Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encumbrance script configs #1481

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix encumbrance script configs #1481

merged 3 commits into from
Dec 18, 2024

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Dec 17, 2024 •
edited
Loading

  • Raise Exception in Exception block instead of SystemExit(1)
  • Go back to using all_done instead of always as the latter will kick off the task before the upstream is complete.
  • Do not use any retries when task fails

@jgreben jgreben marked this pull request as ready for review December 17, 2024 18:57
@jgreben jgreben merged commit e4f6a81 into main Dec 18, 2024
4 checks passed
@jgreben jgreben deleted the no-enc-retries branch December 18, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermnelson jermnelson jermnelson approved these changes

@shelleydoljack shelleydoljack shelleydoljack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgreben @jermnelson @shelleydoljack