Add caching headers and sulu twig parameters #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/caching-headers
branch
2 times, most recently
from
5313a1c to
fcc5e76
Compare
alexander-schranz
force-pushed
the
feature/caching-headers
branch
from
fcc5e76 to
a3d3ed2
Compare
|
|
||
| if (!is_array($cacheLifetime) | ||
| || !isset($cacheLifetime['type']) | ||
| || !isset($cacheLifetime['value']) |
There was a problem hiding this comment.
@wachterjohannes not sure if I should check is_array, isset or just let it run into an error when it not exists.
wachterjohannes
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add caching and sulu twig parameters.
Why?
Articles are currently not cached.
BC Breaks/Deprecations
_cacheLifetime will return the seconds instead of whole cacheLifetime array.
To Do