Extracted routable-behavior from article-subscriber #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/routable-behavior
branch
from
b62b301 to
66bd233
Compare
wachterjohannes
force-pushed
the
feature/routable-behavior
branch
from
3a1f052 to
0e63c2d
Compare
alexander-schranz
requested changes
Mar 23, 2017
| @@ -86,7 +86,7 @@ public function testPost($title = 'Test-Article', $template = 'default') | |||
| $this->assertEquals($title, $response['title']); | |||
| $this->assertEquals(self::$typeMap[$template], $response['articleType']); | |||
| $this->assertEquals($template, $response['template']); | |||
| $this->assertEquals(new \DateTime('2016-01-01'), new \DateTime($response['authored'])); | |||
| $this->assertEquals('2016-01-01', (new \DateTime($response['authored']))->format('Y-m-d')); | |||
There was a problem hiding this comment.
would use the classic way here: date('Y-m-d', strtotime($response['authored']))
| @@ -130,7 +130,7 @@ public function testPut($title = 'Sulu is awesome', $locale = 'de', $article = n | |||
| $response = json_decode($client->getResponse()->getContent(), true); | |||
| $this->assertNotEquals($article['title'], $response['title']); | |||
| $this->assertEquals($title, $response['title']); | |||
| $this->assertEquals(new \DateTime('2016-01-01'), new \DateTime($response['authored'])); | |||
| $this->assertEquals('2016-01-01', (new \DateTime($response['authored']))->format('Y-m-d')); | |||
| @@ -155,7 +155,7 @@ public function testGetGhost() | |||
| $response = json_decode($client->getResponse()->getContent(), true); | |||
| $this->assertNotEquals($article['title'], $response['title']); | |||
| $this->assertEquals($title, $response['title']); | |||
| $this->assertEquals(new \DateTime('2016-01-01'), new \DateTime($response['authored'])); | |||
| $this->assertEquals('2016-01-01', (new \DateTime($response['authored']))->format('Y-m-d')); | |||
alexander-schranz
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR improves the separation of concerns by extracting the route-stuff from the article subscriber.
Why?
This part will be used also for the pages afterwards in the multi-page feature.
To Do
ArticleSubscriber