added authored date and settings tab #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/authored-date
branch
3 times, most recently
from
771706a to
5aeaeda
Compare
wachterjohannes
force-pushed
the
feature/authored-date
branch
from
5aeaeda to
f43f34d
Compare
| * | ||
| * @return $this | ||
| */ | ||
| public function setAuthored($authored) |
There was a problem hiding this comment.
If this is not able to be null add the following line to __construct:
$this->authored = new \DateTime();
|
it would also make sense to add an |
|
tests worked for me locally so it seems more a travis-ci setup problem. |
wachterjohannes
force-pushed
the
feature/authored-date
branch
from
5ec642e to
f4225b4
Compare
| @@ -283,6 +288,15 @@ private function persistDocument($data, $document, $locale) | |||
| ); | |||
| } | |||
|
|
|||
| private function getAuthors(array $authors) | |||
wachterjohannes
force-pushed
the
feature/authored-date
branch
from
f4225b4 to
7df1602
Compare
| * | ||
| * @var int[] | ||
| */ | ||
| protected $authors; |
There was a problem hiding this comment.
shouldnt we initiliazed this as array that it always return an array?
@wachterjohannes
wachterjohannes
force-pushed
the
feature/authored-date
branch
from
7df1602 to
a25a391
Compare
| private function getAuthors(array $authors) | ||
| { | ||
| if (0 === count($authors)) { | ||
| return [$this->getUser()->getContact()->getId()]; |
There was a problem hiding this comment.
I would only do this when the document is created not on edit when the author is removed.
|
missing translations: sulu_article.authored, sulu_article.authors, ... |
|
event missing when only change authors. I think you need to throw tab dirty on |
wachterjohannes
force-pushed
the
feature/authored-date
branch
from
a25a391 to
be9cf20
Compare
wachterjohannes
force-pushed
the
feature/authored-date
branch
from
be9cf20 to
78507bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds an authored date to article.
To Do