Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented by-type and by-template route-generator #14

Merged
merged 6 commits into from
Aug 18, 2016
Merged

Implemented by-type and by-template route-generator #14

merged 6 commits into from
Aug 18, 2016

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Aug 17, 2016 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs sulu/sulu#2820
License MIT
Documentation PR none

What's in this PR?

This PR implements a by-type and by-template route-generator to individualize the generation of routes per-type or per-template.

Example Usage

sulu_route:
    mappings:
        Sulu\Bundle\ArticleBundle\Document\ArticleDocument:
            generator: schema
            options:
                article: /article/{object.getTitle()}
                lexicon: /lexicon/{object.getTitle()}

To Do

  • Tests

@wachterjohannes wachterjohannes mentioned this pull request Aug 17, 2016
Merged
2 tasks
@wachterjohannes wachterjohannes force-pushed the feature/custom-route-generator branch 3 times, most recently from ab1031f to 4e653a1 Compare August 18, 2016 14:49
chirimoya
chirimoya reviewed Aug 18, 2016
View reviewed changes
Routing/ArticleRouteGeneratorByTemplate.php
*/
class ArticleRouteGeneratorByTemplate implements RouteGeneratorInterface
{
use TypeTrait;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@wachterjohannes wachterjohannes force-pushed the feature/custom-route-generator branch from 4e653a1 to 7a3c60f Compare August 18, 2016 14:58
@chirimoya chirimoya merged commit cfebfb9 into develop Aug 18, 2016
@chirimoya chirimoya deleted the feature/custom-route-generator branch August 18, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachterjohannes @chirimoya