Added filter by category to article-list #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/filter-category
branch
from
bf4a8ef to
3f6dd49
Compare
wachterjohannes
changed the title
wachterjohannes
force-pushed
the
feature/filter-category
branch
2 times, most recently
from
a447dcc to
ec239af
Compare
wachterjohannes
changed the title
wachterjohannes
force-pushed
the
feature/filter-category
branch
from
ec239af to
b21e5ed
Compare
wachterjohannes
force-pushed
the
feature/filter-category
branch
from
b21e5ed to
f9811fa
Compare
wachterjohannes
changed the title
alexander-schranz
requested changes
Apr 20, 2017
| * @return {String} | ||
| */ | ||
| getContactFilterTitle: function(filterKey, contact) { | ||
| getFilterTitle: function(filterKey, contact, category) { | ||
| var title = ''; | ||
|
|
||
| switch(filterKey) { | ||
| case 'all': | ||
| title = this.translations.filterAll; | ||
| break; | ||
| case 'filterBy': |
wachterjohannes
force-pushed
the
feature/filter-category
branch
from
8fa363c to
49c6bbf
Compare
alexander-schranz
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR add the filter by category button to article-list.
To Do