Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented sorting pages #179

Merged
merged 5 commits into from
Jun 7, 2017
Merged

Implemented sorting pages #179

merged 5 commits into from
Jun 7, 2017

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented May 31, 2017 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT

What's in this PR?

This PR adds the functionallity to sort pages within an article.

To Do

  • UI
    • focus the moved row
    • flash the moved row
    • disable if only one page exists
  • API
  • Tests

@wachterjohannes wachterjohannes changed the title Added ui for sorting pages Implemented sorting pages May 31, 2017
@wachterjohannes wachterjohannes force-pushed the feature/sort-pages branch 2 times, most recently from 49892a5 to 160df9e Compare June 1, 2017 05:54
@wachterjohannes wachterjohannes added this to the 0.6.0 milestone Jun 1, 2017
@alexander-schranz
Copy link
Member

alexander-schranz commented Jun 1, 2017 •
edited
Loading

@wachterjohannes

  1. When clicking ok without change the sorting an error appears: Missing parameter pages in Sulu\Bundle\ArticleBundle\Controller\ArticleController

  2. Draft message is not shown when change the sorting

  3. Page seems to be broken because of strange urls:

The page is not published yet but the index contains strange: urls {{ dump(pages) }} (on website):

bildschirmfoto 2017-06-01 um 17 16 06

But the db only contains:

bildschirmfoto 2017-06-01 um 17 16 18

This how it is shown in the backend:

bildschirmfoto 2017-06-01 um 17 18 49

Preview:

bildschirmfoto 2017-06-01 um 17 21 19

  1. After publishing (which needs a change in the content before you can publish it) the strange urls are also in the table:

bildschirmfoto 2017-06-01 um 17 12 00

Code I didnt review yet.

@wachterjohannes wachterjohannes force-pushed the feature/sort-pages branch 3 times, most recently from 6745ea0 to 9bfc331 Compare June 6, 2017 07:57
@alexander-schranz alexander-schranz merged commit 10d56e5 into sulu:develop Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wachterjohannes @alexander-schranz