Implemented twig methods sulu_article_load_recent sulu_article_load_similar
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 13, 2017 09:16
added 3 commits
June 14, 2017 10:23
wachterjohannes
requested changes
Jun 14, 2017
| use Sulu\Bundle\ArticleBundle\Document\ArticleViewDocumentInterface; | ||
| use Sulu\Component\DocumentManager\DocumentManagerInterface; | ||
|
|
||
| class ArticleResourceItemFactory |
There was a problem hiding this comment.
phpdoc also on classes and interfaces
| * | ||
| * @return ArticleResourceItem | ||
| */ | ||
| public function getResourceItem(ArticleViewDocumentInterface $articleViewDocument) |
There was a problem hiding this comment.
use createResurceItem - factory creates items
| @@ -86,6 +86,17 @@ public function getConfigTreeBuilder() | |||
| ->end() | |||
| ->end() | |||
| ->scalarNode('display_tab_all')->defaultTrue()->info("Display tab 'all' in list view")->end() | |||
| ->arrayNode('search_fields') | |||
There was a problem hiding this comment.
update config:dump in installation.md
| use Sulu\Bundle\ArticleBundle\Metadata\ArticleViewDocumentIdTrait; | ||
| use Sulu\Component\DocumentManager\DocumentManagerInterface; | ||
|
|
||
| class ArticleViewDocumentRepository |
| } | ||
|
|
||
| /** | ||
| * @param int $limit |
There was a problem hiding this comment.
always add a description for function
| $search->addQuery(new TermQuery('uuid', $excludeUuid), BoolQuery::MUST_NOT); | ||
| } | ||
|
|
||
| $search->addSort(new FieldSort('published')); |
There was a problem hiding this comment.
hmm in my opinion should be authored
added 2 commits
June 14, 2017 13:41
| * | ||
| * @return DocumentIterator | ||
| */ | ||
| public function findRecent($excludeUuid = null, $limit, array $types = null, $locale) |
There was a problem hiding this comment.
provide a default for limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Implemented twig methods
sulu_article_load_recentsulu_article_load_similarandArticleViewDocumentRepository.