Add alternates links to sitemap provider and fix sulu compatibility #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/sitemap-provider-alternates
branch
3 times, most recently
from
a2419cc to
49c09b2
Compare
alexander-schranz
force-pushed
the
feature/sitemap-provider-alternates
branch
2 times, most recently
from
a543d88 to
2a042f3
Compare
alexander-schranz
force-pushed
the
feature/sitemap-provider-alternates
branch
from
2a042f3 to
c4f801b
Compare
alexander-schranz
requested review from
wachterjohannes
and removed request for
trickreich
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix the bc break and add alternates urls.
Why?
A bc break was done in https://github.com/sulu/sulu/pull/3401/files.
Currently no alternates links where provided.
Example Usage
calling
/sitemaps/articles-1.xmlBC Breaks/Deprecations
Yes in sulu.