Added filter for author/creator #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wachterjohannes In my opinion this would be nice a feature und should be included at least in version 1.0 |
|
i would say we do it as soon as possible eventually for 0.3.0? what do you think? |
wachterjohannes
changed the title
wachterjohannes
requested changes
Mar 13, 2017
| @@ -351,4 +351,40 @@ public function getLocalizationState(); | |||
| * @return $this | |||
| */ | |||
| public function setLocalizationState(LocalizationStateViewObject $localizationState); | |||
|
|
|||
| /** | |||
| * @param string $authorId | |||
There was a problem hiding this comment.
add descriptions to this function like the others in this class.
| } | ||
| }); | ||
|
|
||
| listToolbarTemplate.push({ |
There was a problem hiding this comment.
why not retrieving this button also from buttons.get?
contactIdFilter: {
options: {
icon: 'filter',
title: this.translations.filterAll,
group: 2,
...
}
}
| switch(item.id) { | ||
| case 'me': | ||
| contactId = this.sandbox.sulu.user.id; | ||
|
|
| break; | ||
| default: | ||
| contactId = null; | ||
|
|
| @@ -118,6 +118,18 @@ | |||
| <source>sulu_article.smart-content.author-full-name</source> | |||
| <target>Author (alphabetic)</target> | |||
| </trans-unit> | |||
| <trans-unit id="list-filter-01" resname="sulu_article.list.filter.by"> | |||
| <source>sulu_article.list.filter.by</source> | |||
| <target>Only from...</target> | |||
wachterjohannes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
New feature for article list view: Added filter for author/creator.
To Do