Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xliff export for articles #508

Merged

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Aug 3, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs sulu/sulu#5494
License MIT

What's in this PR?

This PR add a command to export the articles as xliff export. In a following PR it will be possible to import the translated file again.

Why?

It should be possible to use the exported file to translate the articles with a tool or a translation agency.

Example Usage

$ bin/adminconsole sulu:article:export export.xliff en

Article Language Export
=======================

Options
Target: export.xliff
Locale: en
Format: 1.2.xliff
---------------

Continue with this options?(y/n) y
Continue!
Loading Data…
 30/30 [============================] 100%
Render Xliff…

To Do

  • Add documentation page

@wachterjohannes wachterjohannes force-pushed the feature/article-xliff-export branch 8 times, most recently from f7757ec to afa3b8a Compare August 3, 2020 09:22
@wachterjohannes wachterjohannes marked this pull request as ready for review August 3, 2020 09:23
@wachterjohannes wachterjohannes force-pushed the feature/article-xliff-export branch from afa3b8a to 4da6a74 Compare August 3, 2020 10:15
@alexander-schranz alexander-schranz added the Feature New functionality not yet included label Sep 11, 2020
@alexander-schranz
Copy link
Member

@wachterjohannes currently the sulu_route.content_type.page_tree_route is not handled. It does not implement the export interface. So articles using the page_tree_route are not correctly exported or imported.

@wachterjohannes
Copy link
Member Author

@alexander-schranz they have implemented it thrue the SimpleContentType which is exportable by default

@alexander-schranz
Copy link
Member

@wachterjohannes its not tagged to be exportable as xliff can you create a PR for fixing this?

@wachterjohannes
Copy link
Member Author

@alexander-schranz have done sulu/sulu#5494

@alexander-schranz alexander-schranz merged commit 1ea2680 into sulu:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants