-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented multilingual articles #68
Conversation
Document/ArticleViewDocument.php
Outdated
/** | ||
* @var string | ||
* | ||
* @Property( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Property(type="string", "options"={"analyzer": "keyword"})
Document/ArticleViewDocument.php
Outdated
protected $uuid; | ||
|
||
/** | ||
* @var string | ||
* | ||
* @Property(type="string") | ||
* @Property( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Property(type="string", "options"={"analyzer": "keyword"})
* @param string $state | ||
* @param string $locale | ||
*/ | ||
public function __construct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should fit in a single line.
/** | ||
* @var string | ||
* | ||
* @Property( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Property(type="string", "options"={"analyzer": "keyword"})
/** | ||
* @var string | ||
* | ||
* @Property( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Property(type="string", "options"={"analyzer": "keyword"})
} | ||
|
||
/** | ||
* Indexes for article-document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update phpdoc
@@ -152,15 +178,70 @@ public function handleRouteUpdate(AbstractMappingEvent $event) | |||
* | |||
* @param AbstractMappingEvent $event | |||
*/ | |||
public function handleIndex(AbstractMappingEvent $event) | |||
public function handleScheduleIndex(AbstractMappingEvent $event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update phpdoc
]; | ||
} | ||
|
||
public function handleFlush(FlushEvent $event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing phpdoc
$this->documents = []; | ||
} | ||
|
||
public function handleFlushLive(FlushEvent $event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing phpdoc
@@ -7,7 +7,9 @@ | |||
* with this source code in the file LICENSE. | |||
*/ | |||
|
|||
define(['suluarticle/services/article-manager'], function(ArticleManager) { | |||
define([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fit in a single line
@trickreich add also some tests for ghost-indexer and article-subscriber |
cannot call reindex command for websiteconsole |
tabs should be hidden for ghost pages edit |
language switcher of list changes type-tab |
the command cannot be called because of this sulu issue sulu/sulu#3196 |
UPGRADE.md
Outdated
@@ -0,0 +1,7 @@ | |||
# Upgrade | |||
|
|||
## 0.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the next version will be 0.2.0
everything fails ): please fix that and give me a hint! |
What's in this PR?
Implemented multilingual articles.
Fix #68