Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented multilingual articles #68

Merged
merged 21 commits into from
Feb 14, 2017
Merged

Conversation

trickreich
Copy link
Contributor

@trickreich trickreich commented Feb 10, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

What's in this PR?

Implemented multilingual articles.

Fix #68

/**
* @var string
*
* @Property(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Property(type="string", "options"={"analyzer": "keyword"})

protected $uuid;

/**
* @var string
*
* @Property(type="string")
* @Property(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Property(type="string", "options"={"analyzer": "keyword"})

* @param string $state
* @param string $locale
*/
public function __construct(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fit in a single line.

/**
* @var string
*
* @Property(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Property(type="string", "options"={"analyzer": "keyword"})

/**
* @var string
*
* @Property(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Property(type="string", "options"={"analyzer": "keyword"})

}

/**
* Indexes for article-document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update phpdoc

@@ -152,15 +178,70 @@ public function handleRouteUpdate(AbstractMappingEvent $event)
*
* @param AbstractMappingEvent $event
*/
public function handleIndex(AbstractMappingEvent $event)
public function handleScheduleIndex(AbstractMappingEvent $event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update phpdoc

];
}

public function handleFlush(FlushEvent $event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing phpdoc

$this->documents = [];
}

public function handleFlushLive(FlushEvent $event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing phpdoc

@@ -7,7 +7,9 @@
* with this source code in the file LICENSE.
*/

define(['suluarticle/services/article-manager'], function(ArticleManager) {
define([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fit in a single line

@wachterjohannes
Copy link
Member

@trickreich add also some tests for ghost-indexer and article-subscriber

@wachterjohannes
Copy link
Member

cannot call reindex command for websiteconsole bin/websiteconsole sulu:article:index-rebuild de --clear --live

@wachterjohannes
Copy link
Member

tabs should be hidden for ghost pages edit

@wachterjohannes
Copy link
Member

language switcher of list changes type-tab

@wachterjohannes
Copy link
Member

when i try to edit and publish an article i get following error on PUT:

image

@wachterjohannes
Copy link
Member

the command cannot be called because of this sulu issue sulu/sulu#3196

UPGRADE.md Outdated
@@ -0,0 +1,7 @@
# Upgrade

## 0.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the next version will be 0.2.0

@wachterjohannes
Copy link
Member

everything fails ): please fix that and give me a hint!

@wachterjohannes wachterjohannes merged commit bec7610 into develop Feb 14, 2017
@wachterjohannes wachterjohannes deleted the feature/multilingual branch February 14, 2017 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants