Implemented is-published function for route-provider #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
added
the
bug
wachterjohannes
force-pushed
the
bugfix/404-for-unpublished
branch
from
8a5969d to
b223385
Compare
| ->useAttributeAsKey('name') | ||
| ->prototype('array') | ||
| ->children() | ||
| ->arrayNode('translations') |
There was a problem hiding this comment.
Use translations instead of config.
wachterjohannes
force-pushed
the
bugfix/404-for-unpublished
branch
from
b223385 to
d02e877
Compare
wachterjohannes
force-pushed
the
bugfix/404-for-unpublished
branch
from
d02e877 to
8c97a70
Compare
trickreich
added a commit
that referenced
this pull request
Jul 31, 2018
* Webspace settings frontend * Fix StyleCI * Fixed bug * PHPCR Implementation (#4) * Implementation finished * Add tests * Add ES indexing * Info just gray * Check for ES in test * Add install notes * Better doc * Better doc * Fix bug in addition webspaces preselect * Fixed bug * Dataprovider considers webspace settings (#5) * Implementation finished * Dataprovider considers webspace settings * Code clean up * Corrected property param * Update ArticleDataProvider.php * Resolve Sitemap correctly (#6) * Add Canonical Tag (#7) * Add Canonical Tag * Code clean up * Target webspace (#8) * Add targetWebspace to ViewDocument * Fixed test * Search Subscriber (#10) * ArticleSearchSubscriber * Code clean up * Fix tests * Add "ignoreWebspaces" param to twig extension (#9) * Add "ignoreWebspaces" param to twig extension * Code clean up * Finishing (#11) * Add UPGRADE note * Add NL translations * Add FR translation * Fix indention * Fix StyleCI * Page tree route (#12) * Page tree route * Disable webspace settings form * Fix StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes the defaults-provider for unpublished articles.
Why?
If an article was never released there was an error.