Implemented copy locale feature #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickreich
force-pushed
the
feature/copy-locale
branch
from
360cff2 to
6f88c49
Compare
wachterjohannes
requested changes
Feb 15, 2017
| @@ -170,6 +184,9 @@ define([ | |||
| this.bindCustomEvents(); | |||
| this.showDraftLabel(); | |||
| this.setHeaderBar(true); | |||
| this.loadLocalizations(); | |||
|
|
|||
| this.options.language = this.options.locale; | |||
There was a problem hiding this comment.
add a comment why we add this option
| @@ -182,7 +199,30 @@ define([ | |||
|
|
|||
| this.sandbox.on('sulu.header.language-changed', function(item) { | |||
| this.sandbox.sulu.saveUserSetting(this.options.config.settingsKey, item.id); | |||
There was a problem hiding this comment.
nothing should be done for the same locale
| * | ||
| * @returns {string} | ||
| */ | ||
| getCopyLocaleUrl: function(id, src, dest) { |
| @@ -182,7 +199,30 @@ define([ | |||
|
|
|||
| this.sandbox.on('sulu.header.language-changed', function(item) { | |||
There was a problem hiding this comment.
extract this to own function
|
@wachterjohannes Have a look once more, thx :) |
| return [ | ||
| '/admin/api/articles/', id, '?locale=', src, '&dest=', dest, '&action=copy-locale' | ||
| ].join(''); | ||
| return ArticleManager.getCopyLocaleUrl(id,src,dest); |
| return [ | ||
| '/admin/api/articles/', id, '?locale=', src, '&dest=', dest, '&action=copy-locale' | ||
| ].join(''); | ||
| return ArticleManager.getCopyLocaleUrl(id,src,dest); |
added 2 commits
February 15, 2017 14:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Implemented copy locale feature in list and edit form.
Why?
Cause I had to.. :/