Changed order of handle-route (update before create) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
bugix/route-generation-on-create
branch
2 times, most recently
from
922d268 to
1b1167e
Compare
trickreich
reviewed
Mar 14, 2017
| $article->setAuthorId($author->getId()); | ||
| } | ||
| if ($document->getAuthor() && $author = $this->contactRepository->findById($document->getAuthor())) { | ||
| $article->setAuthorFullName($author->getFullName()); |
There was a problem hiding this comment.
@wachterjohannes Why you are not setting the author id anymore?
There was a problem hiding this comment.
i have only written it in another format - to make it more readable.
There was a problem hiding this comment.
You have changed the function...
There was a problem hiding this comment.
Following line is missing:
$article->setAuthorId($author->getId());
trickreich
reviewed
Mar 14, 2017
| $article->setChangerContactId($changer->getContact()->getId()); | ||
| } | ||
| if ($document->getChanger() && $changer = $this->userManager->getUserById($document->getChanger())) { | ||
| $article->setChangerFullName($changer->getFullName()); |
trickreich
reviewed
Mar 14, 2017
| $article->setCreatorContactId($creator->getContact()->getId()); | ||
| } | ||
| if ($document->getCreator() && $creator = $this->userManager->getUserById($document->getCreator())) { | ||
| $article->setCreatorFullName($creator->getFullName()); |
wachterjohannes
force-pushed
the
bugix/route-generation-on-create
branch
from
1b1167e to
9f23a33
Compare
|
@trickreich fixed. |
trickreich
reviewed
Mar 14, 2017
| @@ -102,7 +102,7 @@ public static function getSubscribedEvents() | |||
| { | |||
| return [ | |||
| Events::HYDRATE => [['handleHydrate', -500]], | |||
| Events::PERSIST => [['handleRoute', 0], ['handleRouteUpdate', 0], ['handleScheduleIndex', -500]], | |||
| Events::PERSIST => [['handleRouteUpdate', 1], ['handleRoute', 0], ['handleScheduleIndex', -500]], | |||
There was a problem hiding this comment.
I thought we make here bigger steps..
There was a problem hiding this comment.
it is here important that this is near to each other and in the right order. if you use a bigger priority you have no route - if you use a smaller you have one.
trickreich
reviewed
Mar 14, 2017
| @@ -277,7 +277,10 @@ define([ | |||
| }, | |||
|
|
|||
| deleteItems: function(ids) { | |||
| this.sandbox.util.save('/admin/api/articles?ids=' + ids.join(','), 'DELETE').then(function() { | |||
| this.sandbox.util.save( | |||
There was a problem hiding this comment.
We should use here the ArticleManager
wachterjohannes
force-pushed
the
bugix/route-generation-on-create
branch
from
9f23a33 to
084b4d6
Compare
|
@trickreich fixed |
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The order of update and create route is important if you want to create an article with an existing route.
Additional changes:
route_pathto create