Update phpstan

Admin/AutomationAdmin.php

@@ -76,7 +76,7 @@ public function configureViews(ViewCollection $viewCollection): void
     }
 
     /**
-     * {@inheritdoc}
+     * @return mixed[]
      */
     public function getSecurityContexts()
     {

Controller/TaskController.php

@@ -16,7 +16,6 @@
 use FOS\RestBundle\View\ViewHandlerInterface;
 use JMS\Serializer\DeserializationContext;
 use JMS\Serializer\SerializerInterface;
-use Nette\Utils\DateTime;
 use Sulu\Bundle\AutomationBundle\Admin\AutomationAdmin;
 use Sulu\Bundle\AutomationBundle\Entity\Task;
 use Sulu\Bundle\AutomationBundle\Exception\TaskNotFoundException;
@@ -44,6 +43,9 @@
  */
 class TaskController extends AbstractRestController implements ClassResourceInterface, SecuredControllerInterface
 {
+    /**
+     * @var string[]
+     */
     private static $scheduleComparators = [
         'future' => ListBuilderInterface::WHERE_COMPARATOR_GREATER_THAN,
         'past' => ListBuilderInterface::WHERE_COMPARATOR_LESS,
@@ -287,7 +289,7 @@ public function postAction(Request $request): Response
             $context
         );
 
-        /** @var DateTime $date */
+        /** @var \DateTime $date */
         $date = date_create_from_format('Y-m-d:H:i:s', $data['date'] . ':' . $data['time']);
 
         $task->setSchedule($date);
@@ -325,7 +327,9 @@ public function putAction(string $id, Request $request): Response
             $context
         );
 
-        $task->setSchedule(date_create_from_format('Y-m-d:H:i:s', $data['date'] . ':' . $data['time']));
+        /** @var \DateTime $dateTime */
+        $dateTime = date_create_from_format('Y-m-d:H:i:s', $data['date'] . ':' . $data['time']);
+        $task->setSchedule($dateTime);
         $task = $this->taskManager->update($task);
 
         $this->entityManager->flush();
@@ -379,7 +383,7 @@ private function getFieldDescriptors(string $type = null): array
     }
 
     /**
-     * {@inheritdoc}
+     * @return string
      */
     public function getSecurityContext()
     {

Controller/TaskHandlerController.php

@@ -17,7 +17,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Task\Handler\TaskHandlerFactoryInterface;
+use Task\TaskBundle\Handler\TaskHandlerFactory;
 
 /**
  * Provides simple-api for task-handler.
@@ -28,9 +28,12 @@ class TaskHandlerController
 {
     use RequestParametersTrait;
 
+    /**
+     * @var TaskHandlerFactory
+     */
     protected $taskHandlerFactory;
 
-    public function __construct(TaskHandlerFactoryInterface $taskHandlerFactory)
+    public function __construct(TaskHandlerFactory $taskHandlerFactory)
     {
         $this->taskHandlerFactory = $taskHandlerFactory;
     }

DependencyInjection/SuluAutomationExtension.php

@@ -26,10 +26,7 @@ class SuluAutomationExtension extends Extension implements PrependExtensionInter
 {
     use PersistenceExtensionTrait;
 
-    /**
-     * {@inheritdoc}
-     */
-    public function prepend(ContainerBuilder $container)
+    public function prepend(ContainerBuilder $container): void
     {
         if ($container->hasExtension('jms_serializer')) {
             $container->prependExtensionConfig(
@@ -82,10 +79,7 @@ public function prepend(ContainerBuilder $container)
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function load(array $configs, ContainerBuilder $container)
+    public function load(array $configs, ContainerBuilder $container): void
     {
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);

Entity/Task.php

@@ -54,7 +54,7 @@ class Task implements TaskInterface
     private $entityId;
 
     /**
-     * @var string
+     * @var string|null
      */
     private $taskId;
 
@@ -163,15 +163,15 @@ public function setEntityId(string $entityId): self
         return $this;
     }
 
-    public function getTaskId(): string
+    public function getTaskId(): ?string
     {
         return $this->taskId;
     }
 
     /**
      * @return self
      */
-    public function setTaskId(string $taskId): TaskInterface
+    public function setTaskId(?string $taskId): TaskInterface
     {
         $this->taskId = $taskId;
 

Handler/DocumentPublishHandler.php

@@ -26,7 +26,7 @@ public function __construct(DocumentManagerInterface $documentManager, Translato
     }
 
     /**
-     * {@inheritdoc}
+     * @param string $locale
      */
     protected function handleDocument(WorkflowStageBehavior $document, $locale): void
     {

Handler/DocumentUnpublishHandler.php

@@ -26,7 +26,7 @@ public function __construct(DocumentManagerInterface $documentManager, Translato
     }
 
     /**
-     * {@inheritdoc}
+     * @param string $locale
      */
     protected function handleDocument(WorkflowStageBehavior $document, $locale): void
     {

Metadata/FormMetadataLoader.php

@@ -40,6 +40,9 @@ public function __construct(
         $this->taskHandlerFactory = $taskHandlerFactory;
     }
 
+    /**
+     * @param mixed[] $metadataOptions
+     */
     public function getMetadata(string $key, string $locale, array $metadataOptions): ?MetadataInterface
     {
         if ('task_details' !== $key) {

PageTree/AutomationPageTreeUpdater.php

@@ -48,10 +48,7 @@ public function __construct(
         $this->requestStack = $requestStack;
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function update(BasePageDocument $document)
+    public function update(BasePageDocument $document): void
     {
         $request = $this->requestStack->getCurrentRequest();
         if (!$request) {

PageTree/PageTreeRouteUpdateHandler.php

@@ -65,7 +65,7 @@ public function configureOptionsResolver(OptionsResolver $optionsResolver): Opti
     /**
      * {@inheritdoc}
      */
-    public function supports($entityClass): bool
+    public function supports(string $entityClass): bool
     {
         return is_subclass_of($entityClass, BasePageDocument::class);
     }

Serializer/TaskSerializerSubscriber.php

@@ -45,7 +45,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @return mixed[]
      */
     public static function getSubscribedEvents()
     {
@@ -80,7 +80,7 @@ public function onTaskSerialize(ObjectEvent $event): void
             );
         }
 
-        $executions = $this->taskExecutionRepository->findByTaskUuid($object->getTaskId());
+        $executions = $this->taskExecutionRepository->findByTaskUuid((string) $object->getTaskId());
         if (0 < count($executions)) {
             /** @var SerializationVisitorInterface $serializationVisitor */
             $serializationVisitor = $event->getVisitor();

SuluAutomationBundle.php

@@ -23,10 +23,7 @@ class SuluAutomationBundle extends Bundle
 {
     use PersistenceBundleTrait;
 
-    /**
-     * {@inheritdoc}
-     */
-    public function build(ContainerBuilder $container)
+    public function build(ContainerBuilder $container): void
     {
         $this->buildPersistence(
             [

TaskHandler/TaskHandlerConfiguration.php

@@ -19,7 +19,7 @@ class TaskHandlerConfiguration
     /**
      * Create a new configuration.
      *
-     * @return static
+     * @return TaskHandlerConfiguration
      */
     public static function create(string $title)
     {

Tasks/Model/TaskInterface.php

@@ -63,14 +63,14 @@ public function getEntityId(): string;
     /**
      * Returns taskId.
      */
-    public function getTaskId(): string;
+    public function getTaskId(): ?string;
 
     /**
      * Set taskId.
      *
      * @return TaskInterface
      */
-    public function setTaskId(string $taskId): self;
+    public function setTaskId(?string $taskId): self;
 
     /**
      * Returns host.

Tasks/Scheduler/TaskScheduler.php

@@ -76,7 +76,7 @@ public function reschedule(TaskInterface $task): void
     {
         $workload = $this->createWorkload($task);
 
-        $phpTask = $this->taskRepository->findByUuid($task->getTaskId());
+        $phpTask = $this->taskRepository->findByUuid((string) $task->getTaskId());
         $executions = $this->taskExecutionRepository->findByTask($phpTask);
 
         if ($task->getSchedule() == $phpTask->getFirstExecution()
@@ -105,7 +105,7 @@ public function reschedule(TaskInterface $task): void
      */
     public function remove(TaskInterface $task): void
     {
-        $phpTask = $this->taskRepository->findByUuid($task->getTaskId());
+        $phpTask = $this->taskRepository->findByUuid((string) $task->getTaskId());
         $this->taskRepository->remove($phpTask);
     }
 

composer.json

@@ -34,12 +34,12 @@
         "php-ffmpeg/php-ffmpeg": "^0.14.0",
         "jackalope/jackalope-doctrine-dbal": "^1.3.0",
         "zendframework/zendsearch": "@dev",
-        "phpstan/phpstan": "^0.11.12",
-        "phpstan/phpstan-doctrine": "^0.11.5",
-        "phpstan/phpstan-phpunit": "^0.11.2",
-        "phpstan/phpstan-symfony": "^0.11.6",
-        "thecodingmachine/phpstan-strict-rules": "^0.11.2",
-        "jangregor/phpstan-prophecy": "^0.4.1"
+        "phpstan/phpstan": "^0.12",
+        "phpstan/phpstan-doctrine": "^0.12",
+        "phpstan/phpstan-phpunit": "^0.12",
+        "phpstan/phpstan-symfony": "^0.12",
+        "thecodingmachine/phpstan-strict-rules": "^0.12",
+        "jangregor/phpstan-prophecy": "^0.8"
     },
     "autoload": {
         "psr-4": {

phpstan.neon

@@ -1,5 +1,5 @@
 includes:
-    - vendor/jangregor/phpstan-prophecy/src/extension.neon
+    - vendor/jangregor/phpstan-prophecy/extension.neon
     - vendor/phpstan/phpstan-doctrine/extension.neon
     - vendor/phpstan/phpstan-doctrine/rules.neon
     - vendor/phpstan/phpstan-symfony/extension.neon
@@ -16,9 +16,10 @@ parameters:
         - %currentWorkingDirectory%/Tests/*
         - %currentWorkingDirectory%/vendor/*
     symfony:
-        container_xml_path: %rootDir%/../../../Tests/Application/var/cache/admin/dev/adminAdminDevDebugProjectContainer.xml
+        container_xml_path: %rootDir%/../../../Tests/Application/var/cache/admin/test/Sulu_Bundle_AutomationBundle_Tests_Application_KernelTestDebugContainer.xml
         console_application_loader: Tests/phpstan/console-application.php
     doctrine:
         objectManagerLoader: Tests/phpstan/object-manager.php
+    checkGenericClassInNonGenericObjectType: false
     ignoreErrors:
         - '#Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch()#'