Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ContentProjection from bundle source code #133

Merged
merged 20 commits into from
May 19, 2020
Merged

Remove ContentProjection from bundle source code #133

merged 20 commits into from
May 19, 2020

Conversation

niklasnatter
Copy link
Contributor

@niklasnatter niklasnatter commented Apr 27, 2020 •
edited
Loading

This PR removes the ContentProjection concept from the bundle. In most places, the ContentProjection was plainly replaced with the DimensionContent.

The PR adds a mergeCollection method to the ContentMerger as replacement for the ContentProjectionFactory. Furthermore, the PR renames the ContentCopierInterface:: copyFromContentProjection method to copyFromDimensionContent.

See: #82

@niklasnatter niklasnatter changed the title WIP: Remove ContentProjection from Bundle source code WIP: Remove ContentProjection from bundle source code Apr 27, 2020
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch from dc52013 to 882e339 Compare May 18, 2020 10:08
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch from 33ade68 to 7a8d145 Compare May 18, 2020 12:03
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch from 7a8d145 to b1eb018 Compare May 18, 2020 12:21
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch from b1eb018 to a195a11 Compare May 18, 2020 12:24
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch from f55ba12 to 090d328 Compare May 18, 2020 13:56
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch 2 times, most recently from c26a5e3 to e595e2b Compare May 18, 2020 16:35
@niklasnatter niklasnatter force-pushed the enhancement/remove-projection branch from e595e2b to 8a88c1b Compare May 18, 2020 16:48
@niklasnatter niklasnatter changed the title WIP: Remove ContentProjection from bundle source code Remove ContentProjection from bundle source code May 18, 2020
@alexander-schranz alexander-schranz added the DX Only affecting the end developer label May 19, 2020
@niklasnatter niklasnatter mentioned this pull request May 19, 2020
Merged
@alexander-schranz alexander-schranz merged commit 0cf6d8f into sulu:master May 19, 2020
@alexander-schranz alexander-schranz mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-rath luca-rath luca-rath left review comments

@alexander-schranz alexander-schranz alexander-schranz left review comments

@wachterjohannes wachterjohannes wachterjohannes approved these changes

Assignees

@wachterjohannes wachterjohannes

@alexander-schranz alexander-schranz

Labels
DX Only affecting the end developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklasnatter @wachterjohannes @alexander-schranz @luca-rath