Enhance route generation #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
reviewed
Jun 5, 2020
niklasnatter
reviewed
Jun 5, 2020
| $routePath = $this->routeGenerator->generate( | ||
| $localizedObject, | ||
| $routeGenerationData, |
There was a problem hiding this comment.
i think passing something like this here would be more pragmatic and flexible:
array_merge(
$data,
['_unlocalizedDimensionContent' => $unlocalizedObject, '_localizedDimensionContent' => $localizedObject]
)
this way the route_schema can still access all template properties (and also the seo properties if he really wants to 😅 ). if somebody needs to access a property that is not available in the $data (which should be a edge case), he probably also knows if he needs to access the _unlocalizedDimensionContent or the _localizedDimensionContent.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.