Add type filtering in smart content #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prokyonn
force-pushed
the
feature/smartcontent-type-filter
branch
from
9735c3c to
ad4a80a
Compare
Prokyonn
force-pushed
the
feature/smartcontent-type-filter
branch
from
ad4a80a to
4603051
Compare
Prokyonn
force-pushed
the
feature/smartcontent-type-filter
branch
from
0fb964d to
4588cea
Compare
| ], | ||
| ], | ||
| ]); | ||
|
|
||
| $this->assertContainerBuilderHasParameter('sulu.model.dimension.class', 'TestModel'); | ||
| $this->assertContainerBuilderHasService('sulu.repository.dimension', 'TestRepository'); | ||
| $this->assertContainerBuilderHasService('sulu.repository.dimension', 'Sulu\Bundle\ContentBundle\Tests\Application\ExampleTestBundle\TestRepository'); |
There was a problem hiding this comment.
can we just use the EntityRepository::class here? 🤔
|
|
||
| namespace Sulu\Bundle\ContentBundle\Tests\Application\ExampleTestBundle; | ||
|
|
||
| class TestRepository |
niklasnatter
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to add a type filter in the smart content.