Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan errors #191

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Fix phpstan errors #191

merged 1 commit into from
Jun 23, 2021

Conversation

alexander-schranz
Copy link
Member

No description provided.

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Jun 22, 2021
@alexander-schranz alexander-schranz force-pushed the bugfix/ci-runs branch 2 times, most recently from b20673c to d255354 Compare June 22, 2021 17:48
@coveralls
Copy link

coveralls commented Jun 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 961669041

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 646238640: 0.0%
Covered Lines: 1791
Relevant Lines: 1791
💛 - Coveralls

alexander-schranz
alexander-schranz commented Jun 22, 2021
View reviewed changes
.github/workflows/test-application.yaml
coverage: false
dependency-versions: 'lowest'
tools: 'composer:v1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aslong as we don't have a composer plugin I see no need to use composer:v1 in any of our CI's it just cost us performance and take longer to install.

@alexander-schranz alexander-schranz force-pushed the bugfix/ci-runs branch 5 times, most recently from 9e88653 to 390fe54 Compare June 22, 2021 18:11
@niklasnatter niklasnatter merged commit a0a23b8 into sulu:0.x Jun 23, 2021
@alexander-schranz alexander-schranz deleted the bugfix/ci-runs branch June 23, 2021 08:11
luca-rath pushed a commit to luca-rath/SuluContentBundle that referenced this pull request Feb 10, 2022
@alexander-schranz @luca-rath
Fix phpstan errors (sulu#191)
c2e507e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasnatter niklasnatter Awaiting requested review from niklasnatter

Assignees

@alexander-schranz alexander-schranz

@niklasnatter niklasnatter

Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-schranz @coveralls @niklasnatter