Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set authored and author to null #210

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Oct 13, 2021

Currently errors but also the author and authored can be null and should be able to be set to null. There are projects where author is optional so this fields should be nullable and so removeable and setable by the content manager. Fixes sulu/sulu#4026

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Oct 13, 2021
Copy link
Member

@wachterjohannes wachterjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-schranz Code looks good - but all pipelines failing :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1340861819

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1337129686: 0.0%
Covered Lines: 2009
Relevant Lines: 2009

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants