Fix showing of ghost locale identicator for Example #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4501078881
💛 - Coveralls |
| @@ -25,7 +25,7 @@ | |||
| <entity-name>ghostDimensionContent</entity-name> | |||
| <field-name>Sulu\Bundle\ContentBundle\Tests\Application\ExampleTestBundle\Entity\Example.dimensionContents</field-name> | |||
| <method>LEFT</method> | |||
| <condition>ghostDimensionContent.locale = unlocalizedDimensionContent.ghostLocale AND ghostDimensionContent.stage = 'draft'</condition> | |||
| <condition>dimensionContent.locale IS NULL AND ghostDimensionContent.locale = unlocalizedDimensionContent.ghostLocale AND ghostDimensionContent.stage = 'draft'</condition> | |||
There was a problem hiding this comment.
the ref= here would have a requiremend to unlocalizedDimensionContent and to dimensionContent join but we are currently not supporting soemthing like ref="dimensionContent, unlocalizedDimensionContent" or is there other way to reference other joins in here? Maybe a <join-ref name="" /> instead of ref attribute would make sense here?
There was a problem hiding this comment.
hmm not possible currently like the idea of an own node but would put that into the joins node:
<joins>
<joins ref="...."/>
<joins ref="...."/>
<join ...></join>
</joins>
alexander-schranz
added
the
Bug
alexander-schranz
changed the title
wachterjohannes
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ghostLocaleidenticator is currently show always for the ExampleTestBundle but should only be shown when it was not yet translated into that language. This adopt the query for not give back aghostLocaleif currentlocaleis available.