Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale to query for sitemap-provider #248

Merged
merged 2 commits into from
May 17, 2023
Merged

Add locale to query for sitemap-provider #248

merged 2 commits into from
May 17, 2023

Conversation

wachterjohannes
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5004118963

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 4719986189: 0.0%
Covered Lines: 2516
Relevant Lines: 2516
💛 - Coveralls

@alexander-schranz
Copy link
Member

@wachterjohannes looks good for me can we adopt a test to cover this issue?

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label May 17, 2023
@wachterjohannes wachterjohannes force-pushed the sitemap-provider-locale branch from 50ba9ce to 6dcce91 Compare May 17, 2023 08:53
@wachterjohannes wachterjohannes marked this pull request as ready for review May 17, 2023 09:01
@wachterjohannes wachterjohannes force-pushed the sitemap-provider-locale branch from a533502 to 16593b3 Compare May 17, 2023 13:19
@wachterjohannes
Copy link
Member Author

@alexander-schranz fixed

@wachterjohannes wachterjohannes force-pushed the sitemap-provider-locale branch from 16593b3 to f282e5d Compare May 17, 2023 13:28
@wachterjohannes @alexander-schranz
Apply suggestions from code review
868374a 
Co-authored-by: Alexander Schranz <[email protected]>
@wachterjohannes wachterjohannes force-pushed the sitemap-provider-locale branch from f282e5d to 868374a Compare May 17, 2023 14:00
@alexander-schranz alexander-schranz enabled auto-merge (squash) May 17, 2023 14:01
@alexander-schranz alexander-schranz merged commit 890f158 into sulu:0.x May 17, 2023
@wachterjohannes wachterjohannes deleted the sitemap-provider-locale branch May 17, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachterjohannes @coveralls @alexander-schranz