Add symfony mailer integration #274
Conversation
There was a problem hiding this comment.
@bramtervoort Thank you for working on this 🚀 . I think we should use the same pattern which we currently use in sulu for this kind of things, else it is getting confused having different implementation for the same kind of thing. I added some comments and did not yet have enough time to have a deeper look at the tests and the implementation but wanted to give you feedback as soon as it was possible.
|
Thank you Alexander for your feedback. It will be a couple of day's before I have the time to resolve them properly. |
|
@bramtervoort no problem. Feel free to ping me here or over slack if you need any help. |
|
i made some progress with this. next weekend ill be finishing this. |
alexander-schranz
changed the title
|
There all refactored, i just love that I refactored the form to a fixture if you don't agree I will be happy to turn it into a trait of course. Took some time to finish this all but i hope you can still have a look at it. Happy to resolve more review issues. |
There was a problem hiding this comment.
@bramtervoort Thx for working on this. I added some more comments about the actual implementation.
|
@bramtervoort can you also rebase this branch to solve the conflicts and can you try to update your forks branches. I'm not sure why github action are not started for this PR but maybe it has todo that the fork branches are not up2date think it is worse a try. |
Thx, I will check if can find a little time to work some more on this. |
bramtervoort
force-pushed
the
feature/sf-mailer-in-form-bundle
branch
from
b2504cc to
81e8e37
Compare
bramtervoort
force-pushed
the
feature/sf-mailer-in-form-bundle
branch
from
81e8e37 to
1e94271
Compare
|
There found the time to update this :D thank you for your patience. If i can do anything to fix or improve the code please let me know. ( sorry this took me so long ;) ) |
Created a mailer helper class to send emails using the new sf mailer component. Created a configuration option to switch to varying mail helpers.
refactored them as commented in the reviews
alexander-schranz
force-pushed
the
feature/sf-mailer-in-form-bundle
branch
2 times, most recently
from
e80418a to
d8bdb63
Compare
alexander-schranz
force-pushed
the
feature/sf-mailer-in-form-bundle
branch
from
d8bdb63 to
3cc458b
Compare
|
@bramtervoort Thank you for contributing this 👍 |
alexander-schranz
changed the title
What's in this PR?
Created a mailer helper class to send emails using the new sf mailer
component. Created a configuration option to switch to varying mail
helpers.
Why?
It would be nice to be able to use the new Symfony Mailer component for sending the emails.
Example Usage
In the configuration just state:
Note that the user can now create customer helpers to and wire them in using a tag and this configuration setting.
To Do