Allow multiple form data tabs on parent view #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
requested changes
Feb 2, 2022
There was a problem hiding this comment.
@luca-rath the new poroperty should also be added to the documentation: https://github.com/sulu/SuluFormBundle/blob/2.x/Resources/doc/dynamic.md#list-tab---export
alexander-schranz
requested changes
Feb 2, 2022
Resources/doc/dynamic.md
Outdated
| @@ -132,6 +132,7 @@ sulu_form: | |||
| dynamic_lists: | |||
| sulu_page.page_edit_form: # view key e.g. "sulu_page.page_edit_form" for sulu pages or "sulu_article.edit_form" for sulu articles. | |||
| form: # unique key mostly the same as the template key or a combination between template and property key. | |||
There was a problem hiding this comment.
as reading this command I think we should just use the key as postfix for the viewbuilder, so uniqueness is defined by the yaml key.
luca-rath
commented
Feb 2, 2022
Co-authored-by: Alexander Schranz <[email protected]>
alexander-schranz
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Allow multiple form data tabs on parent view