Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for Symfony 6 #329

Merged
merged 28 commits into from
Jul 15, 2022

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jul 14, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Add compatibility for Symfony 6.

Why?

Compatiblity to Symfony 6 and get ride of deprecated swiftmailer.

@alexander-schranz alexander-schranz force-pushed the feature/upgrade-symfony-6 branch 3 times, most recently from 630d734 to 1882b00 Compare July 14, 2022 19:40
@alexander-schranz alexander-schranz force-pushed the feature/upgrade-symfony-6 branch from 1882b00 to 0827b1a Compare July 14, 2022 19:45
@luca-rath luca-rath merged commit 4b52fdf into sulu:2.4 Jul 15, 2022
@alexander-schranz alexander-schranz deleted the feature/upgrade-symfony-6 branch July 15, 2022 11:04
@rogamoore
Copy link

Would it be possible to release these changes? I noticed that currently our projects are unable to update to Sulu 2.5 because it fails with

!!    Compile Error: Declaration of Sulu\Bundle\FormBundle\Controller\FormWebsite
!!    Controller::getSubscribedServices() must be compatible with Sulu\Bundle\Web
!!    siteBundle\Controller\WebsiteController::getSubscribedServices(): array

From the changes here I guess that should be fixed already. :)

@alexander-schranz
Copy link
Member Author

@rogamoore we want to first test the demo with all upgraded bundles before doing a stable release of the bundles. If you already want to use you can install this via using ^2.5@dev in your composer.json for the sulu/form-bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants