Deprecate CSRF Token loading over render_esi as ESI not longer works to start a Session since Symfony 5.4, this was case in Varnish always #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o start a Session since Symfony 5.4, this was case in Varnish always
|
Kind of a strange error happening: @martinlagler didn't you stumble also over this one? Update: Sounds like an issue with symfony/doctrine-bridge 6.3.12. Tested |
| @@ -32,10 +32,10 @@ | |||
| "symfony/validator": "^4.4 || ^5.0 || ^6.0 || ^7.0", | |||
| "symfony/security-csrf": "^4.4 || ^5.0 || ^6.0 || ^7.0", | |||
| "symfony/translation": "^4.4 || ^5.0 || ^6.0 || ^7.0", | |||
| "twig/twig": "^1.41 || ^2.0 || ^3.0" | |||
| "twig/twig": "^1.41 || ^2.6 || ^3.0" | |||
There was a problem hiding this comment.
for deprecated twig tag
|
The CI error is unrelated and will be fixed as soon as Symfony tags 6.4.18 / 7.2.3: Test against |
|
@alexander-schranz Yes had the same error in this PR(https://github.com/sulu/SuluContentBundle/actions/runs/12989957644/job/36224057617?pr=255), good to know thx. |
martinlagler
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Deprecate CSRF Token loading over render_esi
Why?
As ESI not longer works to start a Session since Symfony 5.4, this was case in Varnish always.
Example Usage
See https://github.com/sulu/SuluFormBundle/blob/2.5.5/Resources/doc/csrf.md