Fix falsy .gitignore file when cache:clear fails #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/gitignore-prio-over-post-install-scripts
branch
from
95f5542 to
15ca37b
Compare
alexander-schranz
added
bug
alexander-schranz
changed the title
alexander-schranz
changed the title
Prokyonn
approved these changes
Jan 9, 2025
alexander-schranz
deleted the
enhancement/gitignore-prio-over-post-install-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Avoid falsely .gitignore file when cache:clear fails.
Why?
Currently there is a bug FriendsOfSymfony/FOSHttpCacheBundle#639. As the
auto-scriptswith cache:clear all called before thegitignorescript the gitignore is not modified correctly and ends in having the composer.lock, symfony.lock and package-lock.json file still excluded. To avoid this we move the scripts to thepost-root-package-installwhere we already modify the .env files.