Improved cache-invalidation for media/contact/account #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
2 times, most recently
from
337c76c to
71d6953
Compare
wachterjohannes
changed the title
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
3 times, most recently
from
78e0794 to
9778e92
Compare
wachterjohannes
changed the title
danrot
suggested changes
Feb 23, 2018
There was a problem hiding this comment.
Have you clarified with @chirimoya if we want that feature?
| return []; | ||
| } | ||
|
|
||
| $ids = $this->converter->convertIdsToGroupedIds($value, ['a' => [], 'c' => []]); |
There was a problem hiding this comment.
Should we maybe introduce constants in this class for a and c?
| if ($alias) { | ||
| $entity->getId()->willReturn(1); | ||
| $this->invalidationHandler->invalidateReference($alias, 1)->shouldBeCalled(); | ||
| } |
There was a problem hiding this comment.
} else {
$this->invalidationhandler->invalidateReference(Argument::any)->shouldNotBeCalled();
}?
|
|
||
| foreach ($result as $item) { | ||
| if ($item->getMediaId()) { | ||
| $mediaReferenceStore->add($item->getMediaId()); |
There was a problem hiding this comment.
Shouldn't also be other stores considered here? AFAIK there could also e.g. pages returned here, right?
There was a problem hiding this comment.
this is already done in preResolve method
| /** | ||
| * Invalidate references when account/contact are persisted. | ||
| */ | ||
| class CacheInvalidationListener |
There was a problem hiding this comment.
Can't we have one of these listeners, instead of adding one in each bundle?
There was a problem hiding this comment.
in which bundle would you add that?
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
from
9778e92 to
09fb6a3
Compare
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
from
09fb6a3 to
f588be9
Compare
|
@danrot this should go green now |
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
from
f588be9 to
f27debe
Compare
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
3 times, most recently
from
f6355c4 to
4b8f184
Compare
danrot
suggested changes
Feb 26, 2018
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
from
4b8f184 to
f18b17f
Compare
danrot
suggested changes
Feb 26, 2018
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
from
f18b17f to
320702b
Compare
wachterjohannes
force-pushed
the
enhancement/account-contact-media-reference-store
branch
from
320702b to
32879b6
Compare
Merged
wachterjohannes
deleted the
enhancement/account-contact-media-reference-store
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR add the reference-store to media/contact/account content-types to improve cache-invalidation.
To Do