Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.4 issue #38

Closed
alengodev opened this issue Sep 23, 2021 · 1 comment
Closed

PHP 7.4 issue #38

alengodev opened this issue Sep 23, 2021 · 1 comment

Comments

@alengodev
Copy link

Remove the trailing comma in the constructor arguments

https://github.com/sulu/web-twig/blob/master/src/ImageExtension.php#L102

to fix the issue in PHP 7.4
Prokyonn added a commit that referenced this issue Sep 23, 2021
@Prokyonn
Remove trailing comma from ImageExtension
cd1b606 
see #38
@Prokyonn Prokyonn mentioned this issue Sep 23, 2021
Merged
niklasnatter pushed a commit that referenced this issue Sep 23, 2021
@Prokyonn
Remove trailing comma from ImageExtension constructor (#39)
c91b8ae 
see #38
@niklasnatter
Copy link
Contributor

Thanks for reporting! Fixed in #39 and released as 2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niklasnatter @alengodev