Skip to content

Commit

Permalink
Update benchmark_serving.py to read and write json-datasets, results …
Browse files Browse the repository at this point in the history
…in UTF8, for better compatibility with Windows (vllm-project#8997)

Signed-off-by: Sumit Dubey <[email protected]>
  • Loading branch information
vlsav authored and sumitd2 committed Nov 14, 2024
1 parent 17f32c3 commit 8f4afe0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions benchmarks/benchmark_serving.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def sample_sharegpt_requests(
fixed_output_len: Optional[int] = None,
) -> List[Tuple[str, int, int, None]]:
# Load the dataset.
with open(dataset_path) as f:
with open(dataset_path, encoding='utf-8') as f:
dataset = json.load(f)
# Filter out the conversations with less than 2 turns.
dataset = [data for data in dataset if len(data["conversations"]) >= 2]
Expand Down Expand Up @@ -139,7 +139,7 @@ def sample_sonnet_requests(
), "'args.sonnet-input-len' must be greater than 'args.prefix-input-len'."

# Load the dataset.
with open(dataset_path) as f:
with open(dataset_path, encoding='utf-8') as f:
poem_lines = f.readlines()

# Tokenize the poem lines.
Expand Down Expand Up @@ -726,7 +726,7 @@ def main(args: argparse.Namespace):
file_name = args.result_filename
if args.result_dir:
file_name = os.path.join(args.result_dir, file_name)
with open(file_name, "w") as outfile:
with open(file_name, "w", encoding='utf-8') as outfile:
json.dump(result_json, outfile)


Expand Down

0 comments on commit 8f4afe0

Please sign in to comment.