Parameterize asset balance number #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2023
|
The PR looks good to me @alxkzmn. One thing that I noticed is that moving from vectors to arrays have downgraded the performance in building the merkle sum tree, contrary to what I thought. In particular, building a mst with 24 levels takes 592 s using array, while it took 12s less before. Not a huge deal, but I suggest reverting these changes. Sorry for the wrong heads up 🥲 |
sifnoc
approved these changes
Jun 7, 2023
|
Merginn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18 by parameterizing the number of assets for the MST node and the Poseidon hasher dimensions. Hasher configs and the circuit generic parameters can be generated using the Python script that takes the number of assets as an argument.