Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webmock #430

Closed
bobbrodie opened this issue Apr 6, 2024 · 0 comments · Fixed by #438
Closed

Upgrade webmock #430

bobbrodie opened this issue Apr 6, 2024 · 0 comments · Fixed by #438
Assignees
Milestone

Comments

@bobbrodie
Copy link
Member

It would be worth upgrading webmock, which will require changes to resolve WebMock::NetConnectNotAllowedError:

  1) JIRA::Resource::Attachment it should behave like a resource with a singular GET endpoint GETs a single resource
     Failure/Error: response = basic_auth_http_conn.request(request)
     
     WebMock::NetConnectNotAllowedError:
       Real HTTP connections are disabled. Unregistered request: GET http://localhost:2990/jira/rest/api/2/issue/10002/attachments/10000 with headers {'Accept'=>'application/json', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Authorization'=>'Basic Zm9vOmJhcg==', 'User-Agent'=>'Ruby'}
     
       You can stub this request with the following snippet:
     
       stub_request(:get, "http://localhost:2990/jira/rest/api/2/issue/10002/attachments/10000").
         with(
           headers: {
       	  'Accept'=>'application/json',
       	  'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
       	  'Authorization'=>'Basic Zm9vOmJhcg==',
       	  'User-Agent'=>'Ruby'
           }).
         to_return(status: 200, body: "", headers: {})
     
       registered request stubs:
     
       stub_request(:get, "http://foo:bar@localhost:2990/jira/rest/api/2/issue/10002/attachments/10000")
     
       ============================================================
bobbrodie added a commit to bobbrodie/jira-ruby that referenced this issue Apr 27, 2024
@bobbrodie bobbrodie linked a pull request Apr 27, 2024 that will close this issue
@bobbrodie bobbrodie self-assigned this Apr 27, 2024
@bobbrodie bobbrodie added this to the v3.0.0 milestone Apr 27, 2024
bobbrodie added a commit that referenced this issue Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant