Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default component heights #859

Closed
connor-baer opened this issue Mar 23, 2021 · 0 comments · Fixed by #984
Closed

Update default component heights #859

connor-baer opened this issue Mar 23, 2021 · 0 comments · Fixed by #984
Assignees
@amelako
Labels
⚛️ component Changes to a React component 🎨 design Requires input from designers
Milestone
v3.0

Comments

@connor-baer
Copy link
Member

connor-baer commented Mar 23, 2021 •
edited
Loading

Addresses DS-18.

Context

A consistent height for components has the following benefits:

  • Seamless experience across platforms (web views)
  • Optimised touch size for mobile web
  • Modular approach / different components composable
  • Simplification of component size definition

List of new component heights

Components to amend

  • Button and derived components (40 → 48)
  • Input and derived components (40 → 48)
  • Search (40 → 48)
  • Select (40 → 48)
  • Selector (base size → 48)
  • Tabs (80 → 48)
  • Spinner (add sizes 32, 48)
  • Tag (34 → 32)
  • Table row (? → 48) → postponed until later
@connor-baer connor-baer added 🎨 design Requires input from designers ⚛️ component Changes to a React component labels Mar 23, 2021
@connor-baer connor-baer added this to the v3.0 milestone Mar 23, 2021
@amelako amelako self-assigned this Jun 17, 2021
@amelako amelako mentioned this issue Jun 18, 2021
Merged
5 tasks
@connor-baer connor-baer linked a pull request Jun 29, 2021 that will close this issue
Update default component heights #984
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amelako amelako

Labels
⚛️ component Changes to a React component 🎨 design Requires input from designers
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Update default component heights sumup-oss/circuit-ui
2 participants
@connor-baer @amelako