-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default component heights #984
Conversation
Hey @amelako, Thanks! |
🦋 Changeset detectedLatest commit: e9e78a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/4XumaeFfGCD3PqXN4bjukkMpNuVT |
ad05f24
to
de2c2b3
Compare
Codecov Report
@@ Coverage Diff @@
## next #984 +/- ##
==========================================
+ Coverage 91.68% 91.70% +0.02%
==========================================
Files 164 165 +1
Lines 3091 3112 +21
Branches 758 758
==========================================
+ Hits 2834 2854 +20
- Misses 227 228 +1
Partials 30 30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some extra things left:
- Changesets. I would suggest:
- One general one for adapting the UI (major)
- One for the new Spinner
size
prop (major) - One for the
Button
API breaking change (major) - One for the new
iconSize
value (design-tokens, minor)
- Codemods
- Button: the
size
changes (mega
becomesgiga
) - Spinner: we should add
size="byte"
to all<Spinner />
to keep them the same size as they used to be
- Button: the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When writing documentation and changesets, I recommend following these general guidelines for concise, easy-to-understand text:
- Use simple language, short sentences, and precise words.
- Provide required context. Each section should be understandable in isolation.
- (For changesets specifically) Use the imperative mood in the past tense.
You can find more helpful writing guidelines here.
7071654
to
beeabbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👏🏻👏🏻👏🏻
Note: we won't add a codemod for the |
Addresses #859.
Purpose
A consistent height for components has the following benefits:
Seamless experience across platforms (web views)
Optimised touch size for mobile web
Modular approach / different components composable
Simplification of component size definition
Approach and changes
Definition of done