Consistently track modal events #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c10a02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/GtdTTDR4FBKi184mpNfc5TxsH2mv |
Codecov Report
@@ Coverage Diff @@
## next #1007 +/- ##
==========================================
- Coverage 90.99% 90.96% -0.04%
==========================================
Files 160 161 +1
Lines 2665 2666 +1
Branches 765 763 -2
==========================================
Hits 2425 2425
- Misses 215 217 +2
+ Partials 25 24 -1
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While migrating the dashboard to the new Modal API (#949), I realized that modal events aren't tracked consistently depending on how a modal is opened or closed. The logic is duplicated in several places which allowed for inconsistencies.
Approach and changes
useModalhook into theModalProvidercomponent. Added tests to verify that tracking events are dispatched no matter how the model is triggered.Definition of done