-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new components for large typography #1273
Conversation
There were small issues with TS and a snapshot
The as prop is required for the Title and the Headline
🦋 Changeset detectedLatest commit: b26d260 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/J41ckvsFbEH2Ruac4FenKT3fs6o5 |
The component was missing snapshot tests for the variants and logic tests for the different elements rendered by the highlight and quote variants
Codecov Report
@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
+ Coverage 92.01% 92.32% +0.30%
==========================================
Files 184 186 +2
Lines 3631 3660 +29
Branches 1171 1181 +10
==========================================
+ Hits 3341 3379 +38
+ Misses 272 263 -9
Partials 18 18
|
Purpose
This PR introduces two new components,
Title
andBodyLarge
, for cases when larger typography should be used—for example on landing pages.It also slightly adjusts the tracking of the current
Headline
component.Approach and changes
Headline
component tracking (patch)Title
component (minor)BodyLarge
component (minor)Definition of done