Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new components for large typography #1273

Merged
merged 19 commits into from
Nov 17, 2021
Merged

Add new components for large typography #1273

merged 19 commits into from
Nov 17, 2021

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Nov 16, 2021

Purpose

This PR introduces two new components, Title and BodyLarge, for cases when larger typography should be used—for example on landing pages.

It also slightly adjusts the tracking of the current Headline component.

Approach and changes

  • Adapted the Headline component tracking (patch)
  • Added new design tokens for the new typography values (minor)
  • Added a new Title component (minor)
  • Added a new BodyLarge component (minor)
  • Extras ✨
    • Fixed Storybook links and deprecation warnings
    • Added missing tests for the Body component
    • Improved typography docs

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2021

🦋 Changeset detected

Latest commit: b26d260

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/circuit-ui Major
@sumup/design-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/J41ckvsFbEH2Ruac4FenKT3fs6o5
✅ Preview: https://oss-circuit-ui-git-large-typography-sumup.vercel.app

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1273 (b26d260) into main (a3e3bfc) will increase coverage by 0.30%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   92.01%   92.32%   +0.30%     
==========================================
  Files         184      186       +2     
  Lines        3631     3660      +29     
  Branches     1171     1181      +10     
==========================================
+ Hits         3341     3379      +38     
+ Misses        272      263       -9     
  Partials       18       18              
Impacted Files Coverage Δ
packages/design-tokens/themes/shared.ts 0.00% <ø> (ø)
packages/design-tokens/utils/theme-prop-type.ts 0.00% <ø> (ø)
packages/circuit-ui/components/Title/Title.tsx 85.71% <85.71%> (ø)
packages/circuit-ui/components/Body/Body.tsx 97.22% <100.00%> (+20.29%) ⬆️
...ages/circuit-ui/components/BodyLarge/BodyLarge.tsx 100.00% <100.00%> (ø)
...ckages/circuit-ui/components/Headline/Headline.tsx 91.66% <100.00%> (+5.00%) ⬆️
.../circuit-ui/components/SubHeadline/SubHeadline.tsx 90.90% <100.00%> (ø)
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

@robinmetral robinmetral marked this pull request as ready for review November 17, 2021 14:16
@robinmetral robinmetral requested a review from a team as a code owner November 17, 2021 14:16
@robinmetral robinmetral removed the request for review from a team November 17, 2021 14:16
@robinmetral robinmetral requested review from connor-baer and amelako and removed request for connor-baer November 17, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant