Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the confirm, notify and alert brand colors #1846

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Nov 22, 2022

Purpose

Update the confirm, notify and alert brand colors.

This doesn't affect contrast or the implementation of components. The visual changes are minimal so this will be released as a patch.

Approach and changes

Updated colors, updated snapshots

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Robin Métral added 2 commits November 22, 2022 09:42
This comes from a change in brand. No significant effect on contrast or implementation in design system components.
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

🦋 Changeset detected

Latest commit: 42ae4c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/design-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 9:22AM (UTC)

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1846 (42ae4c8) into main (071fa01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         170      170           
  Lines        3662     3662           
  Branches     1220     1220           
=======================================
  Hits         3340     3340           
  Misses        303      303           
  Partials       19       19           
Impacted Files Coverage Δ
packages/design-tokens/themes/light.ts 0.00% <ø> (ø)

@robinmetral robinmetral marked this pull request as ready for review November 22, 2022 09:38
@robinmetral robinmetral requested a review from a team as a code owner November 22, 2022 09:38
@robinmetral robinmetral merged commit e08e252 into main Nov 22, 2022
@robinmetral robinmetral deleted the brand-color-tweaks branch November 22, 2022 09:41
@connor-baer connor-baer mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant