Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor design tokens to be fully static #2051

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Conversation

connor-baer
Copy link
Member

Purpose

Linaria requires the theme object to be statically analyzable. This ever-so-slightly improves execution performance when importing the theme.

Approach and changes

  • Hardcode the media queries instead of generating them from the breakpoints

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner April 23, 2023 10:38
@connor-baer connor-baer requested review from robinmetral and removed request for a team April 23, 2023 10:38
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

🦋 Changeset detected

Latest commit: 95fa117

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/design-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Apr 23, 2023 10:38am

@connor-baer connor-baer merged commit 6b82b36 into main Apr 23, 2023
@connor-baer connor-baer deleted the feature/static-theme branch April 23, 2023 10:38
This was referenced Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant