Fix Button font and icon sizes #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 392d63c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## canary #2339 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 252 252
Lines 20274 20275 +1
Branches 1263 1263
=======================================
+ Hits 19661 19662 +1
Misses 600 600
Partials 13 13
|
connor-baer
force-pushed
the
fix/button-font-size
branch
2 times, most recently
from
f7469d9 to
5672207
Compare
connor-baer
force-pushed
the
fix/button-font-size
branch
from
5672207 to
392d63c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
@borisborisov-ux noticed two design details that I had overlooked in Figma while implementing #2299.
Approach and changes
Definition of done