Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the color tokens from the legacy theme #2355

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Dec 21, 2023

Purpose

We introduced semantic color tokens as CSS variables in Circuit UI v6.1. Developers have had plenty of time to migrate their code, so it's time to remove the legacy color tokens.

Approach and changes

  • Removed the color tokens from the legacy JavaScript theme object.
  • Disabled the theme switcher in Storybook. It will be re-enabled once there is a dark theme.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: f43b9ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sumup/design-tokens Major
@sumup/astro-template-circuit-ui Patch
@sumup/circuit-ui Major
@sumup/eslint-plugin-circuit-ui Major
@sumup/remix-template-circuit-ui Patch
@sumup/stylelint-plugin-circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 4:06pm

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f33c269) 96.81% compared to head (f43b9ce) 96.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2355      +/-   ##
==========================================
- Coverage   96.81%   96.78%   -0.04%     
==========================================
  Files         228      227       -1     
  Lines       19016    18833     -183     
  Branches     1172     1173       +1     
==========================================
- Hits        18410    18227     -183     
  Misses        593      593              
  Partials       13       13              
Files Coverage Δ
packages/design-tokens/scripts/build.ts 96.58% <100.00%> (+0.50%) ⬆️
packages/design-tokens/themes/legacy/light.ts 100.00% <100.00%> (ø)
packages/design-tokens/utils/theme-prop-type.ts 100.00% <100.00%> (ø)

@connor-baer connor-baer marked this pull request as ready for review December 21, 2023 16:13
@connor-baer connor-baer requested a review from a team as a code owner December 21, 2023 16:13
@connor-baer connor-baer merged commit 43f357b into canary Dec 21, 2023
@connor-baer connor-baer deleted the chore/remove-legacy-colors branch December 21, 2023 16:16
@connor-baer connor-baer mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant