Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package scope to @sumup-oss #2648

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Aug 14, 2024

Addresses ticket DSYS-738.

Purpose

SumUp's private and public open-source packages all use the @sumup organization scope. This causes conflicts when installing public packages alongside private ones that require authentication and are hosted on a different registry. Users have had to use direct tarball URLs for public packages to work around these conflicts, preventing automated updates using tools like Dependabot.

Approach and changes

  • Rename the package scope from @sumup to @sumup-oss

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: c1e8c73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sumup-oss/circuit-ui Major
@sumup-oss/eslint-plugin-circuit-ui Major
@sumup-oss/icons Major
@sumup-oss/stylelint-plugin-circuit-ui Major
@sumup-oss/design-tokens Major
@sumup-oss/astro-template-circuit-ui Patch
@sumup-oss/remix-template-circuit-ui Patch
next-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:13pm

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.59%. Comparing base (f9581a0) to head (c1e8c73).
Report is 1 commits behind head on next.

Files Patch % Lines
packages/remix-template/app/root.tsx 0.00% 3 Missing ⚠️
packages/cna-template/template/app/layout.tsx 0.00% 2 Missing ⚠️
packages/cna-template/template/app/page.tsx 0.00% 2 Missing ⚠️
...a-template/template/components/DocCard/DocCard.tsx 0.00% 1 Missing ⚠️
packages/cna-template/template/next.config.js 0.00% 1 Missing ⚠️
.../remix-template/app/components/DocCard/DocCard.tsx 0.00% 1 Missing ⚠️
...ackages/remix-template/app/routes/_index/route.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2648   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files         209      209           
  Lines       11883    11883           
  Branches     1499     1499           
=======================================
  Hits        10290    10290           
  Misses       1540     1540           
  Partials       53       53           
Files Coverage Δ
packages/circuit-ui/components/Avatar/Avatar.tsx 77.50% <100.00%> (ø)
packages/circuit-ui/components/Button/Button.tsx 72.72% <ø> (ø)
...ckages/circuit-ui/components/Button/IconButton.tsx 91.17% <ø> (ø)
packages/circuit-ui/components/Button/base.tsx 84.34% <ø> (ø)
...ckages/circuit-ui/components/Calendar/Calendar.tsx 93.52% <100.00%> (ø)
...components/Carousel/components/Buttons/Buttons.tsx 100.00% <100.00%> (ø)
...ckages/circuit-ui/components/Checkbox/Checkbox.tsx 92.22% <100.00%> (ø)
.../circuit-ui/components/CloseButton/CloseButton.tsx 100.00% <100.00%> (ø)
...cuit-ui/components/CurrencyInput/CurrencyInput.tsx 98.91% <100.00%> (ø)
...i/components/CurrencyInput/CurrencyInputService.ts 100.00% <100.00%> (ø)
... and 38 more

@connor-baer connor-baer changed the title Rename package organization to @sumup-oss Rename package scope to @sumup-oss Aug 14, 2024
SumUp's private and public, open source packages all use the `@sumup` organization namespace. This causes conflicts when installing public packages alongside private ones which require authentication and are hosted on a different registry. User have had to use direct tarball URLs for public packages to work around these conflicts which prevents automated updates using tools like dependabot.
@connor-baer connor-baer merged commit f583d05 into next Aug 14, 2024
10 of 12 checks passed
@connor-baer connor-baer deleted the chore/rename-package-org branch August 14, 2024 18:23
@connor-baer connor-baer added this to the v9 milestone Aug 14, 2024
@connor-baer connor-baer mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant