Remove the legacy calendar components #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: fe31692 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -8.81 kB (-1.36%) Total Size: 639 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2677 +/- ##
==========================================
+ Coverage 87.82% 88.45% +0.62%
==========================================
Files 218 210 -8
Lines 12621 12312 -309
Branches 1698 1678 -20
==========================================
- Hits 11085 10891 -194
+ Misses 1486 1371 -115
Partials 50 50
|
sirineJ
reviewed
Oct 17, 2024
| "@types/react-dom": "^18.3.0", | ||
| "@types/react-modal": "^3.16.3", | ||
| "jest-axe": "^9.0.0", | ||
| "moment": "^2.29.4", |
connor-baer
force-pushed
the
feature/remove-legacy-date-pickers
branch
from
73543e1 to
b62465a
Compare
sirineJ
approved these changes
Oct 22, 2024
connor-baer
force-pushed
the
feature/remove-legacy-date-pickers
branch
from
b62465a to
fe31692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The legacy calendar components are inaccessible and use
react-dateswhich depends on the legacymoment.js. Together, these two dependencies make up 54.7% of Circuit UI's bundle size 😱A new Calendar component based on the upcoming Temporal API was added in v8.8. The new DateInput component will be released as part of v9, with a DateRangeInput to follow shortly after. This means the legacy calendar components are fully obsolete and can be removed.
Approach and changes
Definition of done