Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new typography APIs internally #2728

Merged
merged 8 commits into from
Oct 17, 2024

Merge branch 'next' into feature/typography-migration

d49ae88
Select commit
Loading
Failed to load commit list.
Merged

Migrate to the new typography APIs internally #2728

Merge branch 'next' into feature/typography-migration
d49ae88
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 17, 2024 in 1s

86.93% (-0.17%) compared to b37eec9

View this Pull Request on Codecov

86.93% (-0.17%) compared to b37eec9

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.93%. Comparing base (b37eec9) to head (d49ae88).

Files with missing lines Patch % Lines
templates/nextjs/template/app/page.tsx 0.00% 2 Missing ⚠️
templates/remix/app/routes/_index/route.tsx 0.00% 2 Missing ⚠️
...cuit-ui/components/Step/examples/MultiStepForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2728      +/-   ##
==========================================
- Coverage   87.10%   86.93%   -0.17%     
==========================================
  Files         211      211              
  Lines       11920    11912       -8     
  Branches     1542     1527      -15     
==========================================
- Hits        10383    10356      -27     
- Misses       1487     1506      +19     
  Partials       50       50
Files with missing lines Coverage Δ
...ages/circuit-ui/components/BodyLarge/BodyLarge.tsx 100.00% <ø> (ø)
...ckages/circuit-ui/components/Calendar/Calendar.tsx 93.23% <100.00%> (ø)
...i/components/Carousel/components/Status/Status.tsx 100.00% <100.00%> (ø)
...ckages/circuit-ui/components/ListItem/ListItem.tsx 87.61% <100.00%> (-0.96%) ⬇️
...cuit-ui/components/ListItemGroup/ListItemGroup.tsx 82.71% <100.00%> (-1.24%) ⬇️
.../NotificationFullscreen/NotificationFullscreen.tsx 96.66% <100.00%> (ø)
...mponents/NotificationInline/NotificationInline.tsx 97.53% <100.00%> (-0.06%) ⬇️
...components/NotificationModal/NotificationModal.tsx 94.31% <100.00%> (ø)
...components/NotificationToast/NotificationToast.tsx 100.00% <100.00%> (ø)
...components/DesktopNavigation/DesktopNavigation.tsx 100.00% <100.00%> (ø)
... and 8 more

... and 3 files with indirect coverage changes

View more details on Codecov