Fix useScrollLock instances issue #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 417925a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2860 +/- ##
=======================================
Coverage 87.83% 87.84%
=======================================
Files 225 225
Lines 13005 13012 +7
Branches 1776 1777 +1
=======================================
+ Hits 11423 11430 +7
Misses 1528 1528
Partials 54 54
|
|
Size Change: +53 B (+0.01%) Total Size: 679 kB
ℹ️ View Unchanged
|
connor-baer
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #DSYS-883
Purpose
When testing nested modals, I noticed that two different instances of the
useScrollLockcollided and scroll lock no longer functioned as expected. On a single web page, we only need to disable scroll on the body element once. If a second instance of the hook is introduced by a second component, its cleanup fn will restore the scroll thus canceling the effect of the first instance.Approach and changes
Keep track of the number instances of the
useScrollLockhook and only execute cleanup fn for the first instance.Definition of done