Export component styles without global reset #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19bb68a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 223 223
Lines 12933 12933
Branches 1747 1747
=======================================
Hits 11372 11372
Misses 1506 1506
Partials 55 55 |
|
Size Change: +20.7 kB (+3.07%) Total Size: 695 kB
ℹ️ View Unchanged
|
matoous
approved these changes
Jan 27, 2025
🚀 Your packages were publishedPublished Packages:
|
sirineJ
approved these changes
Jan 27, 2025
This was referenced Jan 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2237.
Purpose
CSS resets are used to reduce browser inconsistencies in things like default line heights, margins and font sizes of headings, and so on. All browsers have presentation defaults, but no browsers have the same defaults.
Circuit UI’s global base styles are pretty opinionated and can clash with other frameworks or styles used on a page. This pull request exports a new CSS bundle without the global style reset to prevent these kinds of conflicts.
Approach and changes
@sumup-oss/circuit-ui/experimental/styles.cssDefinition of done